Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDE Warning: Removing redundant qualifiers name #16638

Merged
merged 11 commits into from
Jun 23, 2024

Conversation

shalenMathew
Copy link
Contributor

Purpose / Description

Fix Android Studio code inspection warnings.

Fixes

Approach

Android studio suggested the names were redundant

How Has This Been Tested?

Have been tested on emulator

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@BrayanDSO BrayanDSO added the squash-merge The pull request currently requires maintainers to "Squash Merge" label Jun 23, 2024
@BrayanDSO
Copy link
Member

As a suggestion for a next PR, try learning about git rebase on the web so you can make a PR with no merge commits, since we try to have a linear git history

@BrayanDSO BrayanDSO merged commit 301f0a1 into ankidroid:main Jun 23, 2024
11 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Jun 23, 2024
@github-actions github-actions bot removed the squash-merge The pull request currently requires maintainers to "Squash Merge" label Jun 23, 2024
@shalenMathew
Copy link
Contributor Author

As a suggestion for a next PR, try learning about git rebase on the web so you can make a PR with no merge commits, since we try to have a linear git history

Ok

Copy link
Contributor

Hi there @shalenMathew! This is the OpenCollective Notice for PRs merged from 2024-06-01 through 2024-06-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup]: Fix Android Studio Warnings
2 participants