-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix legacy bug and update to depend anki 2.1.36 #36
Conversation
…ntruduced after 3.1.28 f592672fa
in the server,need update graves usn as maxusn avoid sync serve log: sanity check failed with server: graves had usn = -1 such as issue ankicommunity#28 second comment
deck/card/note must not been synced after client add
Once client items in graves have been removed in the server, need update graves usn to current max usn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I still need to check your legacy bug fix but I've left some comments in the meantime. This PR also closes #31.
Also try and keep minor changes like the homepage change and version bumps as separate PRs because they'll get merged easier and quicker.
Do we need to adjust the version of anki when we upgrade it requirements.txt Then update the PIP tool library? Thank you very much for your continuous update and maintenance of anki upgrade. Thank you very much |
@VikashKothary just split to small prs.
|
with patch align rslib get_subnode impl with anki pythonapi find_deck_in_tree #805
align rslib get_subnode impl with anki pythonapi find_deck_in_tree ankitects/anki#805
once not apply the patch , the nestdeck sync will fail,lead to recheck database errro on desktop.
So you can only use the nonnestdeck without the patch.
avoid sync serve log: sanity check failed with server: graves had usn = -1 such as issue Sync crashes after deck deletion #28
second comment
Note: Look like the bug intruduced after the 2.1.28, so the update dependency is not related with the bug fixed.
Now test to be working with anki 2.1.36 desktop , AnkiDroid 2.13.5.