Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix legacy bug and update to depend anki 2.1.36 #36

Closed
wants to merge 7 commits into from

Conversation

cecini
Copy link
Contributor

@cecini cecini commented Oct 27, 2020

  • update ankisyncd _homepage
  • enable V2 scheduler
  • update dependency anki and ankirspy to 2.1.36(06292a45f304fc3c9ea2ef09789b090b2e368016),
    with patch align rslib get_subnode impl with anki pythonapi find_deck_in_tree #805
    align rslib get_subnode impl with anki pythonapi find_deck_in_tree ankitects/anki#805
    once not apply the patch , the nestdeck sync will fail,lead to recheck database errro on desktop.
    So you can only use the nonnestdeck without the patch.
  • fix the remove deck lead server crash issue Sync crashes after deck deletion #28,change intruduced after 3.1.28 f592672fa
  • fix: once client items in graves have been remove in the server,need update graves usn as maxusn
    avoid sync serve log: sanity check failed with server: graves had usn = -1 such as issue Sync crashes after deck deletion #28
    second comment
  • fix client add then delete item then sync issue, deck/card/note must not been synced after client add
  • ensure mediadir exsit in the case full sync ok after delete server collection dir

Note: Look like the bug intruduced after the 2.1.28, so the update dependency is not related with the bug fixed.

Now test to be working with anki 2.1.36 desktop , AnkiDroid 2.13.5.

in the server,need update graves usn as maxusn
avoid sync serve log: sanity check failed with
server: graves had usn = -1 such as issue ankicommunity#28
second comment
deck/card/note must not been synced after client add
@cecini
Copy link
Contributor Author

cecini commented Oct 30, 2020

Once client items in graves have been removed in the server, need update graves usn to current max usn.
The bug look like that set server=True is not working, initially use the self.col.db.execute("update graves set usn=? where usn=-1", self.maxUsn) to fix ,now use the chang the ankisyncserve boostrap way to open collection as server mode(to pass info to rsbackend), so the card/note/deck remove will add grave entry to the grave table and set usn as maxusn(in remove impl of rsbackend)

Copy link
Member

@VikashKothary VikashKothary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

I still need to check your legacy bug fix but I've left some comments in the meantime. This PR also closes #31.

Also try and keep minor changes like the homepage change and version bumps as separate PRs because they'll get merged easier and quicker.

src/ankisyncd/__init__.py Show resolved Hide resolved
src/requirements.txt Show resolved Hide resolved
src/ankisyncd/sync_app.py Show resolved Hide resolved
@VikashKothary VikashKothary mentioned this pull request Nov 1, 2020
@liu-hz
Copy link

liu-hz commented Nov 2, 2020

Do we need to adjust the version of anki when we upgrade it requirements.txt Then update the PIP tool library? Thank you very much for your continuous update and maintenance of anki upgrade. Thank you very much

@cecini
Copy link
Contributor Author

cecini commented Nov 3, 2020

@VikashKothary just split to small prs.
For your clarity:

@cecini cecini closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants