Address a bug with a developer payload check for the promo codes #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Thomas-Vos @autonomousapps what do you guys think? I know you had problems due to this in the past |
serggl
force-pushed
the
deprecate_payload_security_check
branch
from
82cbb1b to
08d55d1
Compare
|
Looks good to my eyes. I don't expect my project to make use of promos in the foreseeable future, so the only thing I care about is that you keep prepending payloads like |
|
@autonomousapps that part will stay unchanged. At least for now |
serggl
added a commit
that referenced
this pull request
Aug 7, 2017
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
…lab#295) * finally address a bug with a payload check for the promo codes * fix typo
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally.
Based on official comment from google, security checks based on developer payload is not a recommended technique.
Since it isn't really used for anything except of the additional security check, lets drop this extra check.
That should address and fix #156, #200, #291
P.S. Purchase signature check is still in place, no worries.