fix: Fixed dependency issue that causes pip command to raise error #877

devkapilbansal · 2020-09-17T12:16:29Z

Description

Fixed issue when pip package manager related commands raise errors.

Fixes #664

Type of Change:

Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run python run.py.
Run python -m unittest discover tests

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
Update requirements.txt

Code/Quality Assurance Only

My changes generate no new warnings
New and existing unit tests pass locally with my changes

devkapilbansal · 2020-09-17T12:20:45Z

@PrashanthPuneriya I removed some dependencies from requirements. Also, after researching I found that "ensure_str" was included in six==1.12.0. This issue may be due to old virtualenv. This issue was introduced in virtualenv==20.0.0.

I tested it with the same configuration provided by you.

codecov · 2020-09-17T12:20:55Z

Codecov Report

Merging #877 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #877   +/-   ##
========================================
  Coverage    95.99%   95.99%           
========================================
  Files           96       96           
  Lines         5287     5287           
========================================
  Hits          5075     5075           
  Misses         212      212

SanketDG

Looks great, I am pretty sure we can do a more extensive audit and remove many more dependencies.

devkapilbansal · 2020-09-17T15:30:04Z

Yes, @SanketDG in my opinion it's never a good choice to copy whole pip freeze to requirements file as some versions can cause issues later

PrashanthPuneriya

Changing the requirements.txt gives following compatabiltiy issues:-

Though I get the compatability issues. It works fine :)

I found that "ensure_str" was included in six==1.12.0.

But, we still do I have six==1.11.0 in the requirements.txt file right? Though this fixed the issue I still don't have any idea why it did. Can you please explain?

devkapilbansal · 2020-09-18T10:25:32Z

While installing we have to use url-resolver, that will be taken into effect from October, 2020. Also, there were some dependencies and we don't need to manage their versions. I removed those dependencies so that pip can install the most updated version automatically.
By letting pip choose the version for those dependencies, the issue got fixed.

devkapilbansal · 2020-09-18T10:25:49Z

@PrashanthPuneriya I will remove this conflicts soon.

PrashanthPuneriya · 2020-09-18T10:30:54Z

While installing we have to use url-resolver, that will be taken into effect from October, 2020. Also, there were some dependencies and we don't need to manage their versions. I removed those dependencies so that pip can install the most updated version automatically.
By letting pip choose the version for those dependencies, the issue probably got fixed.

Okay! But, what change has exactly solved this issue?
@SanketDG Is this PR valid since, it solves more than(to my knowledge) what the issue has stated?

devkapilbansal · 2020-09-18T10:44:33Z

This issue arises due to dependencies of awsebcli that were included in requirements. I removed those dependencies only.

devkapilbansal · 2020-09-18T11:07:32Z

@PrashanthPuneriya compatibility issues are solved now.

devkapilbansal · 2020-09-19T11:36:31Z

@SanketDG @PrashanthPuneriya can you please review it once?

SanketDG

Looks good to me, I guess you could remove many more packages

Pinging @PrashanthPuneriya to see if this is okay to go ahead with

README.md

devkapilbansal · 2020-09-19T14:46:09Z

Looks good to me, I guess you could remove many more packages

Pinging @PrashanthPuneriya to see if this is okay to go ahead with

@PrashanthPuneriya already open a new issue for that. If someone don't solve it then I will remove and update the dependencies. Here, I focus only on those that might create a problem for six

PrashanthPuneriya

LGTM! I have tested this locally and it works as expected. Haven't encountered any issues. We can go ahead with this.
With this PR we have fixed all the errors we used to encounter while setting up the project @SanketDG @isabelcosta :)
Thanks a lot for your contribution @KapilBansal320 :)

README.md

SanketDG · 2020-09-21T05:17:33Z

Feel free to change the commit message and PR title to something more explanatory

We have a Commit Message Style Guide

devkapilbansal · 2020-09-21T08:14:13Z

@PrashanthPuneriya @SanketDG I made the necessary changes as asked.

PrashanthPuneriya

LGTM!

devkapilbansal · 2020-09-25T19:44:25Z

@isabelcosta Please review it

SanketDG · 2020-09-26T15:34:56Z

are the README changes needed?

I honestly don't think so, given just suggesting pip install -U virtualenv does not work at all on most systems because of pip being installed as a system library. Please correct me if I am wrong.

devkapilbansal · 2020-09-26T18:14:45Z

I honestly don't think so, given just suggesting pip install -U virtualenv does not work at all on most systems because of pip being installed as a system library. Please correct me if I am wrong.

@SanketDG the problem occurs in old versions of virtualenv. If we are proceeding by making virtualenv first (as explained in docs), then why pip install -U virtualenv will not work. Also, can you please explain what you mean by

pip being installed as a system library
If README changes still seems unnecessary, then I will revert them.

SanketDG · 2020-09-26T20:12:38Z

Also, can you please explain what you mean by

That pip is installed generally as root, so if you are not the root user, you have to use sudo.

devkapilbansal · 2020-09-26T20:20:44Z

That pip is installed generally as root, so if you are not the root user, you have to use sudo.
Then pip may not work for installing dependencies too. 🤔

SanketDG · 2020-09-26T21:19:45Z

Then pip may not work for installing dependencies too.

No, because then you'd be already inside the virtualenv, right?

devkapilbansal · 2020-09-26T21:22:33Z

Okay @SanketDG should I remove changes in README.md?? Although this is not only for Linux and they may use sudo if needed while updating virtualenv

SanketDG · 2020-09-27T05:32:42Z

I think the code block changes are good, just remove the installation step

Fixed issue when pip package manager related commands raises error Updated the documentation Fixes #664

devkapilbansal · 2020-09-27T09:57:10Z

I think the code block changes are good, just remove the installation step

@SanketDG changes done now.

vj-codes

LGTM 🎉

SanketDG

Looks good!

devkapilbansal · 2020-10-21T09:49:34Z

@PrashanthPuneriya can you please test and verify that the pip dependency issues are solved now. Once it is done we can move it to ready to merge

PrashanthPuneriya · 2020-10-21T11:17:12Z

Tested locally and haven't encountered any dependency issues or any other issues. It is safe to merge this PR.

isabelcosta

good work @devkapilbansal !
I deployed this to a Heroku link and this worked fine 🎉

…-org#877) Fixes anitab-org#664

SanketDG reviewed Sep 17, 2020

View reviewed changes

devkapilbansal changed the title ~~Fix: Fixxed issue #664~~ Fix: Fixed issue #664 Sep 17, 2020

devkapilbansal mentioned this pull request Sep 17, 2020

Bug: pip package manager related commands raises error #664

Closed

PrashanthPuneriya reviewed Sep 18, 2020

View reviewed changes

devkapilbansal requested review from SanketDG and PrashanthPuneriya September 18, 2020 10:45

ravi5175 previously approved these changes Sep 18, 2020

View reviewed changes

SanketDG previously approved these changes Sep 19, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

PrashanthPuneriya previously approved these changes Sep 20, 2020

View reviewed changes

devkapilbansal dismissed stale reviews from PrashanthPuneriya, SanketDG, and ravi5175 via 5ceb31f September 20, 2020 07:55

devkapilbansal requested review from SanketDG and PrashanthPuneriya September 20, 2020 07:59

PrashanthPuneriya reviewed Sep 20, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

devkapilbansal requested a review from PrashanthPuneriya September 20, 2020 21:11

devkapilbansal changed the title ~~Fix: Fixed issue #664~~ fix: Fixed dependency issue that causes pip command to raise error Sep 21, 2020

PrashanthPuneriya previously approved these changes Sep 21, 2020

View reviewed changes

SanketDG previously approved these changes Sep 23, 2020

View reviewed changes

devkapilbansal requested a review from PrashanthPuneriya September 25, 2020 19:43

PrashanthPuneriya previously approved these changes Sep 26, 2020

View reviewed changes

devkapilbansal dismissed stale reviews from PrashanthPuneriya and SanketDG via f0e8acf September 26, 2020 17:57

fix: Fixed dependency issues that causes pip command to raise error

796e53b

Fixed issue when pip package manager related commands raises error Updated the documentation Fixes #664

devkapilbansal requested a review from SanketDG September 27, 2020 10:03

PrashanthPuneriya approved these changes Sep 27, 2020

View reviewed changes

vj-codes approved these changes Sep 27, 2020

View reviewed changes

SanketDG approved these changes Sep 27, 2020

View reviewed changes

vj-codes added the Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. label Sep 27, 2020

PrashanthPuneriya added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Oct 21, 2020

isabelcosta temporarily deployed to ms-backend-review-pr-877 October 25, 2020 00:05 Inactive

isabelcosta approved these changes Oct 25, 2020

View reviewed changes

isabelcosta merged commit 0efacf9 into anitab-org:develop Oct 25, 2020

devkapilbansal deleted the issues/664 branch October 25, 2020 04:42

b-thebest pushed a commit to b-thebest/mentorship-backend that referenced this pull request Mar 2, 2021

fix: dependency issues that causes pip command to raise error (anitab…

29266ef

…-org#877) Fixes anitab-org#664

RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021

fix: dependency issues that causes pip command to raise error (anitab…

a356fad

…-org#877) Fixes anitab-org#664

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixed dependency issue that causes pip command to raise error #877

fix: Fixed dependency issue that causes pip command to raise error #877

devkapilbansal commented Sep 17, 2020 •

edited

Loading

devkapilbansal commented Sep 17, 2020 •

edited

Loading

codecov bot commented Sep 17, 2020 •

edited

Loading

SanketDG left a comment

devkapilbansal commented Sep 17, 2020

PrashanthPuneriya left a comment

devkapilbansal commented Sep 18, 2020 •

edited

Loading

devkapilbansal commented Sep 18, 2020

PrashanthPuneriya commented Sep 18, 2020

devkapilbansal commented Sep 18, 2020

devkapilbansal commented Sep 18, 2020

devkapilbansal commented Sep 19, 2020 •

edited

Loading

SanketDG left a comment

devkapilbansal commented Sep 19, 2020

PrashanthPuneriya left a comment •

edited

Loading

SanketDG commented Sep 21, 2020 •

edited

Loading

devkapilbansal commented Sep 21, 2020

PrashanthPuneriya left a comment

devkapilbansal commented Sep 25, 2020

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020 •

edited

Loading

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020 •

edited

Loading

SanketDG commented Sep 27, 2020

devkapilbansal commented Sep 27, 2020

vj-codes left a comment

SanketDG left a comment •

edited

Loading

devkapilbansal commented Oct 21, 2020 •

edited

Loading

PrashanthPuneriya commented Oct 21, 2020

isabelcosta left a comment

fix: Fixed dependency issue that causes pip command to raise error #877

fix: Fixed dependency issue that causes pip command to raise error #877

Conversation

devkapilbansal commented Sep 17, 2020 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

devkapilbansal commented Sep 17, 2020 • edited Loading

codecov bot commented Sep 17, 2020 • edited Loading

Codecov Report

SanketDG left a comment

Choose a reason for hiding this comment

devkapilbansal commented Sep 17, 2020

PrashanthPuneriya left a comment

Choose a reason for hiding this comment

devkapilbansal commented Sep 18, 2020 • edited Loading

devkapilbansal commented Sep 18, 2020

PrashanthPuneriya commented Sep 18, 2020

devkapilbansal commented Sep 18, 2020

devkapilbansal commented Sep 18, 2020

devkapilbansal commented Sep 19, 2020 • edited Loading

SanketDG left a comment

Choose a reason for hiding this comment

devkapilbansal commented Sep 19, 2020

PrashanthPuneriya left a comment • edited Loading

Choose a reason for hiding this comment

SanketDG commented Sep 21, 2020 • edited Loading

devkapilbansal commented Sep 21, 2020

PrashanthPuneriya left a comment

Choose a reason for hiding this comment

devkapilbansal commented Sep 25, 2020

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020 • edited Loading

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020

SanketDG commented Sep 26, 2020

devkapilbansal commented Sep 26, 2020 • edited Loading

SanketDG commented Sep 27, 2020

devkapilbansal commented Sep 27, 2020

vj-codes left a comment

Choose a reason for hiding this comment

SanketDG left a comment • edited Loading

Choose a reason for hiding this comment

devkapilbansal commented Oct 21, 2020 • edited Loading

PrashanthPuneriya commented Oct 21, 2020

isabelcosta left a comment

Choose a reason for hiding this comment

devkapilbansal commented Sep 17, 2020 •

edited

Loading

devkapilbansal commented Sep 17, 2020 •

edited

Loading

codecov bot commented Sep 17, 2020 •

edited

Loading

devkapilbansal commented Sep 18, 2020 •

edited

Loading

devkapilbansal commented Sep 19, 2020 •

edited

Loading

PrashanthPuneriya left a comment •

edited

Loading

SanketDG commented Sep 21, 2020 •

edited

Loading

devkapilbansal commented Sep 26, 2020 •

edited

Loading

devkapilbansal commented Sep 26, 2020 •

edited

Loading

SanketDG left a comment •

edited

Loading

devkapilbansal commented Oct 21, 2020 •

edited

Loading