Migrate to github actions and add codecov bot #654
Conversation
|
@techno-disaster Since you have experience with this can you kindly review? Thanks a lot!! 🎉 💯 |
| | :---: | :---: | :---: | :---: | | ||
| | [master](https://github.com/anitab-org/mentorship-backend/tree/master) | [](https://travis-ci.org/anitab-org/mentorship-backend) | [](https://www.codacy.com/app/systers/mentorship-backend) | [Production](http://systers-mentorship.eu-central-1.elasticbeanstalk.com/) | | ||
| | [develop](https://github.com/anitab-org/mentorship-backend/tree/develop) | [](https://travis-ci.org/anitab-org/mentorship-backend) | [](https://www.codacy.com/app/systers/mentorship-backend) | [Development](https://mentorship-backend-temp.herokuapp.com/) | | ||
|  |
There was a problem hiding this comment.
this is the badge for run tests only right? Build is another badge? Also could you get a badge for codecov?
There was a problem hiding this comment.
Are we not using Codacy anymore 🤔 I actually am not sure cc @mayburgos
There was a problem hiding this comment.
Hey @isabelcosta the travis script just runs the tests and then publishes on aws as I directly converted the travis script into gh actions 😅
There was a problem hiding this comment.
The codacy thing I am not sure about @isabelcosta 😅 I figured I didn't see the test running so we might not be using it but not sure
deploy.sh
Outdated
| @@ -1,49 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Not sure if we should remove this file because the Herokuhoosting should be a temporary thing. Perhaps we could keep it and leave a comment as this is not being currently used 🤔
There was a problem hiding this comment.
Yeah sure will edit @isabelcosta ✌️
Tlazypanda
force-pushed
the
migrate_github_actions
branch
from
b17c5ec to
cb5ba32
Compare
Tlazypanda
force-pushed
the
migrate_github_actions
branch
from
cb5ba32 to
aaf2427
Compare
|
@isabelcosta Have added the codecov badge and the deploy.sh file back 😅 also just asking here we have the codedcov application setup on anitab-org right (under the settings tab in github under applications) ? I am assuming that since we are using codecov for the flutter app it has been already setup 😅 |
There was a problem hiding this comment.
Looks good @Tlazypanda :)
Looking forward to see this working.
|
@Tlazypanda can you ask for additional reviews on Zulip, after we have one more I am more than happy to merge this |
isabelcosta
changed the title
|
I will merge this and see how it goes. |
chore: migrate to github actions and add codecov bot (anitab-org#654)
Description
Migrated to github actions and eliminated travis related files. Added support for codecov in gh action script along with codecov bot to comment on every pr. Readme edited to add gh actions status badge. Removed travis script (github workflow is used now) and deploy.sh script (since aws services no longer in use )
Fixes #659
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Tested on my fork of mentorship-backend.
Checklist:
Code/Quality Assurance Only