Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code for tests/users/test_dao.py #1115

Closed
wants to merge 1 commit into from

Conversation

aakankshaagr
Copy link
Contributor

@aakankshaagr aakankshaagr commented May 25, 2021

Description

Fixes # [ISSUE]

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

Tested on my local pc

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@aakankshaagr aakankshaagr requested a review from isabelcosta as a code owner May 25, 2021 07:08
@epicadk
Copy link
Member

epicadk commented May 25, 2021

Are you sure you've linked the correct issue? I don't think this is what the author was looking for.

@codesankalp
Copy link
Member

Yes, This PR (https://github.com/anitab-org/mentorship-backend/pull/1112/files) have some changes according to the issue but the current one do not have any changes related to the issue

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1115 (c012786) into develop (83c64db) will decrease coverage by 3.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1115      +/-   ##
===========================================
- Coverage    96.00%   92.90%   -3.10%     
===========================================
  Files           96       38      -58     
  Lines         5309     2073    -3236     
===========================================
- Hits          5097     1926    -3171     
+ Misses         212      147      -65     
Impacted Files Coverage Δ
app/api/resources/mentorship_relation.py 96.51% <0.00%> (-1.24%) ⬇️
app/messages.py 100.00% <0.00%> (ø)
app/api/models/user.py 100.00% <0.00%> (ø)
app/api/api_extension.py 100.00% <0.00%> (ø)
app/api/jwt_extension.py 100.00% <0.00%> (ø)
app/api/models/mentorship_relation.py 100.00% <0.00%> (ø)
app/schedulers/delete_unverified_users_cron_job.py 100.00% <0.00%> (ø)
tests/task_comments/test_api_get_task_comments.py
tests/tasks/test_dao_delete_task.py
tests/utils/test_username_validation.py
... and 72 more

@aakankshaagr
Copy link
Contributor Author

aakankshaagr commented May 25, 2021

Sorry I have linked the wrong issue. I am trying to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants