Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1099

Merged
merged 1 commit into from
May 23, 2021
Merged

Update README.md #1099

merged 1 commit into from
May 23, 2021

Conversation

keshavgbpecdelhi
Copy link
Contributor

@keshavgbpecdelhi keshavgbpecdelhi commented May 14, 2021

Description

Fixes #1100

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • Update Postman API at /docs folder
  • Update Swagger documentation and the exported file at /docs folder
  • Update requirements.txt

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@devkapilbansal
Copy link
Member

@isabelcosta Although the change looks good, there is no issue for this.

@vj-codes
Copy link
Member

@keshavgbpecdelhi hey the org has a specific workflow for contributors to follow here on Github
Can you please create an issue regarding this change and comment to claim it, once it's assigned to you this PR can be reviewed .
Until then I'll put this on hold, if you have any questions about this do ask here :)

@vj-codes vj-codes added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label May 14, 2021
@devkapilbansal
Copy link
Member

This PR deals with a single word change and I don't think that issue opening is required for this. Will ask @isabelcosta to mention this in Issue LifeCycle too

@epicadk epicadk removed the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label May 18, 2021
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devkapilbansal devkapilbansal added the Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. label May 18, 2021
@devkapilbansal
Copy link
Member

Adding Ready to Merge since it is a documentation change

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for contributing @keshavgbpecdelhi

@isabelcosta isabelcosta merged commit 25d8d99 into anitab-org:develop May 23, 2021
RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme.md update
5 participants