refactor : move schema constants to db/constant.js file (foyzulka…

…rim#28)

client/src/sections/@dashboard/products/VideoCard.js

@@ -41,8 +41,7 @@ export default function VideoCard({ video }) {
     console.log('clicked', video);
   };
 
-  let videoDuration = 0
-  if(duration) videoDuration = duration
+  const videoDuration = duration ?? 0;
 
   return (
     <Card onClick={onClickHandler}>

server/scripts/seed-data/video.js

@@ -1,6 +1,6 @@
 const { faker } = require('@faker-js/faker');
 const { MongoManager } = require('../../src/modules/db/mongo');
-const { VIDEO_STATUS, VIDEO_VISIBILITIES } = require('../../src/modules/db/schemas/videos');
+const { VIDEO_STATUS, VIDEO_VISIBILITIES } = require('../../src/modules/db/constant');
 
 const getFakeVideosData = (x) => {
   const videos = [];

server/src/modules/db/constant.js

@@ -0,0 +1,26 @@
+
+const PUBLIC_VISIBILITY = 'Public';
+const PRIVATE_VISIBILITY = 'Private';
+const UNLISTED_VISIBILITY = 'Unlisted';
+
+const VIDEO_VISIBILITIES = [PUBLIC_VISIBILITY, PRIVATE_VISIBILITY, UNLISTED_VISIBILITY];
+
+
+
+const PENDING_STATUS = "pending";
+const PROCESSED_STATUS = "processed";
+const PUBLISHED_STATUS = "published"
+
+const VIDEO_STATUS = [PENDING_STATUS, PROCESSED_STATUS, PUBLISHED_STATUS];
+
+
+module.exports = {
+    PENDING_STATUS,
+    PROCESSED_STATUS,
+    PUBLISHED_STATUS,
+    VIDEO_STATUS,
+    PUBLIC_VISIBILITY, 
+    PRIVATE_VISIBILITY, 
+    UNLISTED_VISIBILITY,
+    VIDEO_VISIBILITIES
+}

server/src/modules/db/schemas/videos.js

@@ -1,7 +1,6 @@
 const { baseSchema, ensureCollection } = require('./common');
 
-const VIDEO_VISIBILITIES = ['Public', 'Private', 'Unlisted'];
-const VIDEO_STATUS = ["pending", "processed", "published"];
+const { VIDEO_STATUS, VIDEO_VISIBILITIES } = require('../constant');
 
 const name = 'videos';
 
@@ -144,6 +143,4 @@ const updateSchema = async (db) => {
 
 module.exports = {
   updateSchema,
-  VIDEO_STATUS,
-  VIDEO_VISIBILITIES,
 };

server/src/modules/models/video/controller.js

@@ -10,7 +10,7 @@ const {
 const { validate } = require('./request');
 const { VIDEO_QUEUE_EVENTS: QUEUE_EVENTS } = require('../../queues/constants');
 const { addQueueItem } = require('../../queues/queue');
-const { getVideoDuration } = require('../../queues/video-processor');
+const { getVideoMetadata } = require('../../queues/video-processor');
 
 const BASE_URL = `/api/videos`;
 
@@ -136,15 +136,19 @@ const setupRoutes = (app) => {
   app.post(`${BASE_URL}/upload`, uploadProcessor, async (req, res) => {
     try {
 
-      const videoDuration = await getVideoDuration(`./${req.file.path}`)
+      const videoMetadata = await getVideoMetadata(`./${req.file.path}`)
+      let videoDuration = 0
+      if (typeof videoMetadata != Error){
+        videoDuration = parseInt(videoMetadata.format.duration)
+      }
+
       const dbPayload = {
         ...req.body,
         fileName: req.file.filename,
-        originalName: req.file.originalname,
+        originalName: req.file.originalname, 
         recordingDate: new Date(),
         videoLink: req.file.path,
         viewCount:0,
-        status: "pending",
         duration:videoDuration
       };
       console.log('dbPayload', dbPayload);

server/src/modules/models/video/handler.js

@@ -1,6 +1,7 @@
 const eventEmitter = require('../../../event-manager').getInstance();
 const { VIDEO_QUEUE_EVENTS } = require('../../queues/constants');
 const { updateHistory, update } = require('./service');
+const { PUBLISHED_STATUS } = require('../../db/constant')
 
 const setup = () => {
   // eventEmitter.on(VIDEO_QUEUE_EVENTS.VIDEO_UPLOADED, (data) => {
@@ -27,10 +28,11 @@ const setup = () => {
           hlsPath: data.path,
         });
 
-        const video = await update({ 
+        await update({ 
           _id: data.id,
-          status: "published" 
+          status: PUBLISHED_STATUS
         });
+
         return;
       }
 

server/src/modules/models/video/service.js

@@ -1,11 +1,13 @@
 const { ObjectId } = require('mongodb');
 const { Video } = require('../../db/collections');
+const { PENDING_STATUS } = require('../../db/constant')
+
 
 // TODO: add logging
 
 const insert = async (document) => {
   try {
-    return await Video.insert(document);
+    return await Video.insert({status: PENDING_STATUS, ...document}); // assigning default satus for all new videos
   } catch (error) {
     return error;
   }
@@ -15,7 +17,6 @@ const update = async (document) => {
   try {
     return await Video.update(document);
   } catch (error) {
-    console.error(error);
     return error;
   }
 };

server/src/modules/queues/video-processor.js

@@ -106,23 +106,21 @@ const processMp4ToHls = async (filePath, outputFolder, jobData) => {
     return;
 };
 
-const getVideoDuration = (filePath) => {
+const getVideoMetadata = (filePath) => {
 
-    // if any error occour return 0.0 second as default video duration
-    // else return video duration
+    // if any error occour return error
+    // else return video meta data
     return new Promise((resolve,reject) => {
-        let duration = 0.0
          ffmpeg.ffprobe(filePath, function(err, metadata) {
-            // getting video duration in second
-            if(!err){
-                duration = parseInt(metadata.format.duration)
-            }
-            resolve(duration)
+            if(err){
+                resolve(err);
+            };
+            resolve(metadata);
         });
     })
 
 
 }
 
 
-module.exports = { processRawFileToMp4, processMp4ToHls, generateThumbnail, getVideoDuration };          
+module.exports = { processRawFileToMp4, processMp4ToHls, generateThumbnail, getVideoMetadata };