Fixed issue with wrong compare between seconds and miliseconds

animir · Nov 24, 2023 · abe8fa9 · abe8fa9
1 parent 5189be8
commit abe8fa9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/RateLimiterDynamo.js b/lib/RateLimiterDynamo.js
@@ -221,6 +221,7 @@ class RateLimiterDynamo extends RateLimiterStoreAbstract {
       }
 
       const dateNow = Date.now();
+      const dateNowSec = dateNow / 1000;
       /* -1 means never expire, DynamoDb do not support null values in number fields.
          DynamoDb TTL use unix timestamp in seconds.
       */
@@ -249,7 +250,7 @@ class RateLimiterDynamo extends RateLimiterStoreAbstract {
           ExpressionAttributeValues: {
             ':new_points': {N: points.toString()},
             ':new_expire': {N: newExpireSec.toString()},
-            ':where_expire': {N: dateNow.toString()}
+            ':where_expire': {N: dateNowSec.toString()}
           },
           ConditionExpression: 'expire <= :where_expire OR attribute_not_exists(points)',
           ReturnValues: 'ALL_NEW'
@@ -263,7 +264,7 @@ class RateLimiterDynamo extends RateLimiterStoreAbstract {
           UpdateExpression: 'SET points = points + :new_points',
           ExpressionAttributeValues: {
             ':new_points': {N: points.toString()},
-            ':where_expire': {N: dateNow.toString()}
+            ':where_expire': {N: dateNowSec.toString()}
           },
           ConditionExpression: 'expire > :where_expire',
           ReturnValues: 'ALL_NEW'