Comments on a previous commit

animetosho · Dec 23, 2020 · 3566234 · 3566234
1 parent becc556
commit 3566234
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/nntp.js b/lib/nntp.js
@@ -560,7 +560,7 @@ NNTP.prototype = {
 			if(self._requests.length && self._requests[0].post && state == 'connected')
 				// if posting, can't pipeline on a QUIT message
 				self._end(cb);
-			else if(state == 'connecting' || state == 'closing') {
+			else if(state == 'connecting' || state == 'closing') { // probably shouldn't force destroy if 'closing', but I'm too lazy to wire things across nicely
 				self._destroy();
 				cb();
 			} else
@@ -584,7 +584,7 @@ NNTP.prototype = {
 		var self = this;
 		(function(cb) {
 			if(self.socket) {
-				if(self.state == 'connecting' || self.state == 'closing') {
+				if(self.state == 'connecting' || self.state == 'closing') { // probably shouldn't force destroy if 'closing', but I'm too lazy to wire things across nicely
 					self._destroy();
 					cb();
 				} else

diff --git a/test/nntp.js b/test/nntp.js
@@ -624,7 +624,7 @@ it('should not connect if destroyed straight after', function(done) {
 		], done);
 	});
 
-	it('should notify cancellation if ' + ef + '() during connection', function(done) {
+	it('should notify cancellation if ' + ef + '() whilst connecting', function(done) {
 		var server, client;
 
 		// simulate a connection timeout by hijacking the connect method, so that it does nothing on the first call