Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/server containerization #26

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Feature/server containerization #26

merged 3 commits into from
Mar 1, 2024

Conversation

antunsz
Copy link
Contributor

@antunsz antunsz commented Mar 1, 2024 •
edited by aniketmaurya
Loading

Changes

fixes #24

  • This PR creates a folder in examples, called docker-compose-example with some files showing how to use FastServe with Docker.
  • Also it updates the README.

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@antunsz antunsz requested a review from aniketmaurya as a code owner March 1, 2024 17:06
@antunsz antunsz mentioned this pull request Mar 1, 2024
Closed
@aniketmaurya aniketmaurya added the enhancement New feature or request label Mar 1, 2024
aniketmaurya
aniketmaurya approved these changes Mar 1, 2024
View reviewed changes
Copy link
Owner

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the great work 🚀

@aniketmaurya aniketmaurya merged commit 5554b65 into aniketmaurya:main Mar 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketmaurya aniketmaurya aniketmaurya approved these changes

Assignees

@antunsz antunsz

Labels
enhancement New feature or request example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Dockerfile template
2 participants
@antunsz @aniketmaurya