Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Event listeners do not always propagate exceptions #721

Closed
matanlurey opened this issue Nov 29, 2017 · 2 comments
Closed

Event listeners do not always propagate exceptions #721

matanlurey opened this issue Nov 29, 2017 · 2 comments
Assignees
@matanlurey
Labels
area: runtime ☄ problem: bug

Comments

@matanlurey
Copy link
Contributor

Need to add a regression test, fix, and then close this issue.
@matanlurey matanlurey self-assigned this Nov 29, 2017
@matanlurey
Copy link
Contributor Author

It turns out this is a ~duplicate of #631.

@matanlurey matanlurey changed the title [Placeholder] DebugAppView host events are not rethrown Exceptions thrown in events do not always propagate exceptions Nov 30, 2017
@matanlurey matanlurey changed the title Exceptions thrown in events do not always propagate exceptions Event listeners do not always propagate exceptions Nov 30, 2017
@matanlurey
Copy link
Contributor Author

https://github.com/dart-lang/angular/blob/e81df5fd6733e5cec371b24857ed09ca5b05746e/angular/lib/src/core/linker/app_view.dart#L609-L618

In at least some cases, you are already in the zone...

...so handler() will not trigger the ExceptionHandler. This seems like a serious bug.

alorenzen pushed a commit that referenced this issue Nov 30, 2017
@matanlurey @alorenzen
fix(Core/Runtime): Ensure all caught exceptions in event listeners ar…
4768a3b 
…e caught.

Closes #721.

PiperOrigin-RevId: 177388781
alorenzen pushed a commit that referenced this issue Dec 1, 2017
@matanlurey @alorenzen
fix(Core/Runtime): Ensure all caught exceptions in event listeners ar…
fc1a5d2 
…e caught.

Closes #721.

PiperOrigin-RevId: 177388781
alorenzen pushed a commit that referenced this issue Dec 1, 2017
@matanlurey @alorenzen
fix(Core/Runtime): Ensure all caught exceptions in event listeners ar…
2ef8c2d 
…e caught.

Closes #721.

PiperOrigin-RevId: 177388781
alorenzen pushed a commit that referenced this issue Dec 1, 2017
@matanlurey @alorenzen
fix(Core/Runtime): Ensure all caught exceptions in event listeners ar…
39089c3 
…e caught.

Closes #721.

PiperOrigin-RevId: 177388781
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
area: runtime ☄ problem: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matanlurey