Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat(patch): fix #828, patch socket.io client #994

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

JiaLiPassion
Copy link
Collaborator

fix #828, patch socket.io-client.

I created a sample repo in here, https://github.com/JiaLiPassion/zone-socketio

mhevery
mhevery previously approved these changes Feb 8, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 8, 2018
@mhevery
Copy link
Contributor

mhevery commented Feb 8, 2018

Seems to be failing CI. Will merge as soon as we can get it green. (ping me on slack)

@mhevery mhevery merged commit b3db9f4 into angular:master Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket.IO
3 participants