fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue. #905

JiaLiPassion · 2017-09-16T02:16:47Z

in safari, when trigger RTCPeerConnection event handler this context is not the same with the event target when addEventListener.

<html>
  <head>
    <!--<script src="https://cdnjs.cloudflare.com/ajax/libs/zone.js/0.8.16/zone.js"></script>-->
    <script>
      window.onload = function () {
          console.log('Create RTCPeerConnection')
          const pc = new RTCPeerConnection()

          console.log('Add "track" event listener')
          let event
          pc.addEventListener('track', function(_event) {
            console.log('this === pc', this === pc);
            console.log('track event', _event);
            event = _event
          });
          /*pc.ontrack = function(_event) {
            console.log('this === pc', this === pc);
            console.log('track event', _event);
            event = _event
          };*/

          console.log('Dispatch "track" event')
          pc.dispatchEvent(new Event('track'))

          if (event) {
            console.log('Success!')
          } else {
            console.error('Failure!')
       }
      }
    </script>
  </head>
</html>

in above case, this === pc will be false.

So in this PR, we allow user to load an additional js webapis-rtc-peer-connection.js to let zone.js patch RTCPeerConnection without using the globalCallback.

to make this PR available, please load the js as following order.

 <script src="node_modules/zone.js/dist/zone.js"></script>
 <script src="node_modules/zone.js/dist/webapis-rtc-peer-connection.js"></script>

…riggered issue

fix(event): fix angular#883, fix RTCPeerConnection Safari event not t…

3c4a1b0

…riggered issue

googlebot added the cla: yes label Sep 16, 2017

mhevery approved these changes Sep 17, 2017

View reviewed changes

mhevery merged commit 6f74efb into angular:master Sep 17, 2017

benbro mentioned this pull request Oct 3, 2017

RTCPeerConnection broken on iOS 11.01 Safari #920

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue. #905

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue. #905

JiaLiPassion commented Sep 16, 2017

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue. #905

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue. #905

Conversation

JiaLiPassion commented Sep 16, 2017