This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat(performance): onProperty handler use global wrapFn, other performance improve. #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
performance
branch
from
d451453
to
06d1c9d
Compare
JiaLiPassion
force-pushed
the
performance
branch
from
b44ace1
to
614cc80
Compare
mhevery
approved these changes
Aug 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have use
global callbackinEventTarget.addEventListener, we should also use the same mechanism foronProperty=listenerlogic. We can use a globalwrapFninstead of create a new function every time.other small improvements, basically use
const stringto make sure not create too many strings.Chrome 60 support
HTMLFrameSetElement.prototype.onmessageerror, patch it.