This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add a flush method to the FakeAsync zone spec
#755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
approved these changes
Apr 25, 2017
|
It seems to be failing CI. Could you have a look? Is it ready to merge? |
|
It looks like IE is unhappy about something - I'll debug. |
The `flush` method advances time until all non-periodic timers are cleared from the queue. It has a configurable limit (default 20) of tasks that will be run before it gives up and throws an error, in order to avoid infinite loops when polling timeouts are present. Closes angular#735
|
IE is now happy! I think this is ready for merge unless @vikerman would like to comment. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flushmethod advances time until all non-periodic timersare cleared from the queue. It has a configurable limit (default 20)
of tasks that will be run before it gives up and throws an error,
in order to avoid infinite loops when polling timeouts are present.
Closes #735