This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(REVERT): remove zone internal stack frames in error.stack (#632) #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JiaLiPassion FYI |
|
@mhevery , I have following proposal.
what do you think? |
|
Yes we should brainstorm as to what is the best way to provide this functionality. |
…r#632) This feature was reverted because it was causing a performance regression. The setup of all of the stack traces added about 20-25ms to the total time of the Zone initialization. This was a bit more than 50% of overall time zone needed to initialize. While this is a useful feature, the performance cost does not justify its cost.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was reverted because it was causing a performance regression.
The setup of all of the stack traces added about 20-25ms to the total
time of the Zone initialization. This was a bit more than 50% of overall
time zone needed to initialize. While this is a useful feature, the
performance cost does not justify its cost.