This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix #574, captureStackTrace will have additional stackframe from Zone… #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #574, from zone.js 0.7.x, we have a patched ZoneAwareError, and we patch everything from native Error includes captureStackTrace and prepareStackTrace like this.
It works but will add an additional stack frame, which is the patched function named
value above. So it will break binding.js which try to find the current loaded js filename.
So in this fix, I change the patch function to a named function(zoneCaptureStackTrace),
and remove this stack information when call prepareStackTrace.