Fix #546, #554, #555, the error should keep prototype chain and can be called without new #558

JiaLiPassion · 2016-12-20T18:57:21Z

With the commit #547, the #546, error prototype issue was fixed, but a bigger issue occurs, that
Error object can be created with direct call.

let error = Error('message');

And the #547 PR will break it, cause a lot of errors, such as #554, #555

In this new PR, I checked the this exists or not and checked the this is global or not (non strict mode). So it should fix both #546 and #554, #555.

Please review, Thank you.

…structor, and copy native error's properties

JiaLiPassion added 7 commits December 21, 2016 01:31

fix angular#555, fix angular#554, error should return itself from con…

f166f4a

…structor, and copy native error's properties

copy props from error

cd23d35

copy props from error and check this is valid or not

077de0b

add detection code for node

7072815

add navigator logic for node

67d347d

keep original stack in error when call Error directly

378827f

add test case for call Error() directly and simulate not strict mode

af73106

googlebot added the cla: yes label Dec 20, 2016

merge conflict

e4fdc6d

JiaLiPassion closed this Dec 20, 2016

JiaLiPassion deleted the issue-554 branch December 20, 2016 19:10

Provide feedback