This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(promise): support more aggressive optimization. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoneAwarePromise does not technically implement or inherit the static side of Promise, so aggressive optimizers may drop static methods such as `all`, `race`, `reject`, and `resolve`. This change explicitly exports them into quoted properties, which is harmless for normal use and protects users of more aggressive optimizers, such as Closure Compiler in typed mode.
|
Must be a flake, how would this change cause any change in tests?
|
|
yes it was, master is green. Sorry for the noise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZoneAwarePromise does not technically implement or inherit the static
side of Promise, so aggressive optimizers may drop static methods such
as
all,race,reject, andresolve.This change explicitly exports them into quoted properties, which is
harmless for normal use and protects users of more aggressive
optimizers, such as Closure Compiler in typed mode.