This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(node): node patched method should copy original delegate's symbol properties #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1094
the error can be described as this,
Before this PR, after
promisify
, the promise will berejected
as error.The reason is in
nodejs promisify
implementation, by default, it will handle the nodejs style callback(err, ...values)
to promise, but some of the nodejs API is not in this style, such asfs.exists
, the callback is(exists) => {}
, without the 1sterr
parameter.So
nodejs
provide a mechanism to let those special API provide their ownpromisify
implementation by add asymbol property Symbol(custom)
in the method, for example,fs.exists
provide a custom implementation here, https://github.com/nodejs/node/blob/master/lib/fs.js#L213And this property is defined on the function, so when
zone.js
patched thisfunction
, thesymbol property
got lost, so we need to copy this symbol property.