This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(fakeAsync): fix #1050, should only reset patched Date.now until fakeAsync exit #1051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakeAsyncTestZone should only
resetPatchDate
when fakeAsync finish totally, not afteronInvoke
.such as
in this code, there will be several
zone.run
call which will reset the patchedDate, and make tick not work properly to get the simulated Date. So we must make sure that the patchedDate not reset untilfakeAsync exit.
non resolved promise.then
feature because it will affectangular
current cases.async/fakeAsync
withZone.__load_patch
.window.Date.prototype
to fix Regression: usage of date pipe in template of component tested using fakeAsync makes test fail in 0.8.21 #1064