This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(test): karma-dist should test bundle under dist #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update karma-dist.conf.js
current
karma-dist.conf.js
will load bundles underdist
and the purpose is to test those built bundles instead of the dev version which underbuild
folder.so in
karma-dist.conf.js
, we will loadBut in current test cases will load some of the lib directly from
build
folder, for example inasync-test.spec.ts
, in current version, it will loadso the test case in fact will not test the bundle under
dist
butbuild
.in this PR, I load all needed bundles in
karma-dist.conf.js
and remove all directly import from test specs. And also modify the test entry classes to make sure currently test cases will be ok for bothbuild
test anddist
test.build
.dist
.Also disable ios 8.4 test because saucelabs seems not stable
change default karma browser to Chrome.
change rollup globals.
add ios 11, edge 15, android 7.1 to ci test.