This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat(test): move async/fakeAsync from angular to zone.js #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
async-test
branch
from
22360c3
to
f22a69a
Compare
mhevery
approved these changes
Mar 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move async and fakeAsync from angular/core/testing to zone.js/testing.
rename async to asyncTest.
The motivation is
currently in angular/core/testing, async/fakeAsync doesn't include any angular thing or feature, they use pure zone.js API, so I think those 2 functions should be in zone.js, and we can provide some API to let angular customize some behaviors, such as automatically call fixture.detectChanges when tick in fakeAsync or provide customizedfinishedCallbackofasyncTest`.
move those functions into zone.js can make zone.js to be a useful testing tool for other non-angular applications, they can also use zone.js to handle async unit-test.
it is easy to fix bugs, for example, this issue angular/angular#22448 need both zone.js and angular modify the code, it is difficult to manage versions relationship between angular and zone.js.
@mhevery, @juliemr, @vikerman, could you look into this one? Thank you very much!