-
Notifications
You must be signed in to change notification settings - Fork 407
Error caused by patched XMLHttpRequest #657
Comments
… with done twice
@devoto13 , thank you for posting the issue and the steps to reproduce. xhr.onreadystatechange = function() {
if (xhr.readyState === 4) {
if (xhr['ok']) {
console.log('error duplicate done');
}
xhr['ok'] = true;
}
} it can still be reproduced. So I made a PR to add check to prevent that in zone.js. And I test it with your repo, the error is gone. |
Thank you @JiaLiPassion for a quick fix! I tried Zone.js with your fix in the test application and it seems to work well. I'll try it in the real application as well on Monday and will get back. Do you think we should report this issue with |
@devoto13, it seems that the issue has already been reported, but their cases are hard to reproduce, your case is very easy to reproduce, so I think it will be helpful to report your case to them:) |
Okey, thanks! Will take care about it next week as well. |
… with done twice
Hi, I have a very similar error with 7.7 and higher. I have an Angular2 app connected to a meteor server, and if I update my zone.js version from 7.2 to 7.7 I get the following error everytime I close the browser with the application loaded:
This crash the server (with said error). I dont have any issue with version 7.2, havent tried any intermediate versions, but definetly have the issue with 0.7.7., 0.7.8, 0.8.0 and 0.8.1. |
@AngelCastilloB , can you provide a reproduce repo? thank you. |
@JiaLiPassion The application is very complex, I will try to figure out how to create a simple app that reproduce it. |
@AngelCastilloB , sure , thank you! |
@AngelCastilloB - have you been able to get past this? I am having the same issue. Unfortunately I cannot use zone 0.7.2. |
We have a similar issue like @devoto13 described in his opening post, but the reason is not the same. It's not causing our app to fail, but it throws tons of errors. |
Looks like this issue has been resolved in |
@klaascuvelier i am getting the same issue while using new relic browser library .so only solution is to update the zone js library to 0.8.11? |
@karangarg45 , yes , please update to newest zone.js. |
Yeah @karangarg45 updating will fix it. |
Still have this issue: Error: macroTask 'requestAnimationFrame': can not transition to 'running', expecting state 'scheduled', was 'notScheduled'. (0.8.12) but only in Firefox (54.0.1). |
@interist32 , could you post a reproduce repo? |
@JiaLiPassion, Sorry, seems it's application specific issue. I'll try to reproduce it in isolation and will post here if it will happen again. |
I am also |
@ido-ran , could you post a reproduce repo? |
@JiaLiPassion Unfortuenly we do not have a minimum repro for this issue, it happens as part of a large closed-source application. Will it help if we'll be able to provide you access to the running application, compiled with debug so you can observe the issue live? |
@ido-ran , sure, that will help a lot! thank you. |
OK, I'm working on it, will update soon (I hope 😄) |
Thank you @JiaLiPassion for the help. We've manage to work around this issue by using |
Thank you for sharing the information, I don't know that, usign different
`zone` will resolve such kind of issue.
…On Tue, Dec 12, 2017 at 4:22 PM, Ido Ran ***@***.***> wrote:
Thank you @JiaLiPassion <https://github.com/jialipassion> for the help.
We've manage to work around this issue by using downgradeModule as
explained in Angular NgUpgrade With DowngradeModule
<http://www.syntaxsuccess.com/viewarticle/angular-ngupgrade-with-downgrademodule>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#657 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYDDww0BRfHlmFzaWuIQFWJkwOQhKkIks5s_inLgaJpZM4MRhAS>
.
|
Thank you for direction but i have error and using Angular 5.2. I did not understand the best solution. I don't have previous version of application which is worked with AngularJS. We make application from start for Angular 2 and update it, but still have this issue: |
@vladanPro , could you post a reproduce repo? |
No, repo is private. Sry, this is obvious specific case. |
@vladanPro , if you can create a small reproduce repo, I can help to debug. |
ok thank you i will try. |
I got this same error @JiaLiPassion Here's a plnkr. It happens when you play the video. |
@santialbo , I can't reproduce with your plunker, which browser you are using. |
@JiaLiPassion I can reproduce with the plunker of @santialbo with Firefox 58. We have the same issue with our Angular project: https://peertube.cpy.re/videos/watch/e2651856-4809-408a-99d4-b85b01fefb09 |
@JiaLiPassion Sorry, apparently this only occurs on Firefox |
@santialbo , thank you , I will try to debug it, could you make a repo so I can debug locally? |
@JiaLiPassion here you have it https://github.com/santialbo/video-js-test |
@santialbo ,thanks for the repo, it seems is a even call current walk around is add following flag in (window as any).__Zone_disable_requestAnimationFrame = true;
import 'zone.js/dist/zone'; // Included with Angular CLI. |
@JiaLiPassion I'm also getting a similar error using Cypress
|
@herkulano, please provide a reproduce repo, thanks. |
@JiaLiPassion I've fixed it by moving the Cypress command to another test. I'm guessing the problem was not zone or angular related. Sorry for that. |
@herkulano , you are welcome, but if you could provide a reproduce sample about the error, I am very curious why the |
@herkulano I can reproduce it (in my case i have to subscribe events from the AppComponent/Root-Element because it runs in an chrome extension)
The error occurs when im trying to get events by Reproduce:
Its seems that
|
@SerkanSipahi, thanks, could you provide me a reproduce repo? I can not reproduce with your sample. |
We're using Angular with Zone.js 0.7.7 in the WebView in our mobile application. The problem is that quite often we get following error:
Real application is complex, but we managed to come up with a minimal reproduction. Basically it's mobile application, which does following sequence of actions in the infinite loop with 1s delay:
stringByEvaluatingJavaScript
function.XMLHttpRequest
.Once I scroll page up/down for 2-3 seconds, mentioned error occurs.
setInterval()
inside WebView instead of calling from native code. So it seems to be related to how WebView executes code from outside.ZoneTask._transitionTo()
(O.o). Tried to log unique IDs for every task using approach described here. See commented code. This one looks like a complete magic to me.I understand that this is still pretty complex reproduction, but I have no idea how to reduce it further. Do you have any ideas why it can happen and how can I debug it further? I can also provide any extra details if needed.
Project can be found here. To reproduce you need to open project with XCode, run it on device, connect with Safari remote debugging and scroll up/down for 2-3 seconds. Error is usually reproducible after couple of seconds of scrolling.
The text was updated successfully, but these errors were encountered: