Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

unhandledrejection even is not fired #621

Closed
hmdhk opened this issue Feb 1, 2017 · 3 comments · Fixed by #627
Closed

unhandledrejection even is not fired #621

hmdhk opened this issue Feb 1, 2017 · 3 comments · Fixed by #627

Comments

@hmdhk
Copy link
Contributor

hmdhk commented Feb 1, 2017 •
edited
Loading

According to MDN unhandledrejection event should be fired if the promise rejection is unhandled
@JiaLiPassion
Copy link
Collaborator

I'll add it when promise has unhandledrejection.

such spec doesn't exist in Promise A+ spec current version, it seems promise A+ is making the spec of unhandledrejection now, hope it will be compatible with MDN's definition.

@hmdhk
Copy link
Contributor Author

hmdhk commented Feb 1, 2017

Thanks @JiaLiPassion , FWIW, it is already supported by chrome since version 49

@JiaLiPassion
Copy link
Collaborator

@jahtalab, you are welcome, I'll make a PR and test it in chrome.

@JiaLiPassion JiaLiPassion mentioned this issue Feb 4, 2017
Merged
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Feb 7, 2017
@JiaLiPassion
feat(promise), fix angular#621, add unhandledRejection handler and ig…
2238fe5 
…nore consoleError
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Feb 7, 2017
@JiaLiPassion
feat(promise), fix angular#621, add unhandledRejection handler and ig…
9d05d98 
…nore consoleError
mhevery pushed a commit that referenced this issue Feb 8, 2017
@JiaLiPassion @mhevery
feat(promise): fix #621, add unhandledRejection handler and ignore co…
f3547cc 
…nsoleError (#627)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(promise), fix #621, add unhandledRejection handler and ignore consoleError JiaLiPassion/zone.js
2 participants
@JiaLiPassion @hmdhk