Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Should add precommit hook to do tslint/format/karma/node test #566

Closed
JiaLiPassion opened this issue Dec 27, 2016 · 0 comments · Fixed by #565
Closed

Should add precommit hook to do tslint/format/karma/node test #566

JiaLiPassion opened this issue Dec 27, 2016 · 0 comments · Fixed by #565

Comments

@JiaLiPassion
Copy link
Collaborator

JiaLiPassion commented Dec 27, 2016

Before we commit with git in local, we should precheck

  • tslint
  • format
  • karma
  • test-node

to make sure everything is fine.

mhevery pushed a commit that referenced this issue Jan 12, 2017
… precommit of git (#565)

* fix #532, add tslint in ci, add tslint/karma/testnode/format in git commit hook

* fix #532, add tslint in ci, add tslint/karma/testnode/format in git commit hook

* use format:enforce

* rename package.json script's name

* update developer.md to add precommit details

* change var to const

* add scripts explaination into DEVELOPER.md, use gulp lint

* remove pre-commit hooks

* update DEVELOPER.md to add process for before commit

* format DEVELOPMER.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant