Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

requestAnimationFrame callback arguments not passed in #187

Closed
mhevery opened this issue Sep 29, 2015 · 1 comment · Fixed by #188
Closed

requestAnimationFrame callback arguments not passed in #187

mhevery opened this issue Sep 29, 2015 · 1 comment · Fixed by #188

Comments

@mhevery
Copy link
Contributor

mhevery commented Sep 29, 2015

In alpha36, a requestAnimationFrame's callback correctly gets the timestamp argument:
http://plnkr.co/edit/6ZkphwlO7hUKpoLrBDJw?p=preview

In alpha37, the rAF callback does not get the timestamp argument:
http://plnkr.co/edit/H9bYRx7gDivc5qxkdVB1?p=preview

This causes javascript animations to fail.

Also close: angular/angular#4179
@mhevery mhevery mentioned this issue Sep 29, 2015
Closed
@vicb
Copy link
Contributor

vicb commented Sep 29, 2015

@justindujardin this is probably caused by 3d6dc08

Do you have time to take a look ?

vicb added a commit to vicb/zone.js that referenced this issue Sep 29, 2015
@vicb
fix(RequestAnimationFrame): pass the timestamp to the callback
79a37c0 
fixes angular#187
@vicb vicb mentioned this issue Sep 29, 2015
Merged
@vicb vicb closed this as completed in #188 Sep 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(RequestAnimationFrame): pass the timestamp to the callback vicb/zone.js
2 participants
@mhevery @vicb