This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 407
fakeAsync test fails with RxJS 6 #1056
Comments
@cexbrayat , thank you for posting the issue, I will test it. |
@cexbrayat , This is a |
JiaLiPassion
added a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 26, 2018
JiaLiPassion
added a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 26, 2018
mhevery
pushed a commit
to JiaLiPassion/zone.js
that referenced
this issue
Mar 30, 2018
mhevery
pushed a commit
that referenced
this issue
Mar 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There is a possible problem with RxJS 6 in fakeAsync tests, and I think this might be on zone.js part, so I'm opening the issue here instead of on the Angular repo.
Let's take a simple component, with an
interval
observable modifying a field every second,in a brand new CLI app (cli 1.7.2, ng 5.2.9, rxjs 5.5.7, zone.js 0.8.20):
We can write a simple test for this, verifying that when we tick 1 second, the title is updated:
The test is a success.
Now, when we bump the app to RxJS 6 (6.0.0-beta.1 ATM) and ng 6 (6.0.0-rc.0 ATM), and relaunch the same test fails:
I then suppose this is an issue with zone.js and RxJS 6 (but maybe it's Angular
fakeAsync
, or RxJS itself?). I have this issue an a more complex project, this is a dumbed down example.If you need easy reproduction, I created a repo with it: https://github.com/cexbrayat/rxjs6
master
contains the CLI app, with the test succeeding in RXJS 5.5.chore/rxjs6
contains the commit bumping to RXJS 6. Just runyarn
andng test
to see the issue.PR https://github.com/cexbrayat/rxjs6/pull/1 shows the difference between the two branches.
The text was updated successfully, but these errors were encountered: