No more completion for components / HTML tags in Ivy mode #1140

cyrilletuzi · 2021-02-22T15:50:35Z

Describe the bug

When enabling the Ivy language service, there is no more components / HTML tags completion/suggestions at all.

To Reproduce

Steps to reproduce the behavior:

npm i @angular/cli -g
ng new demo --inline-template (and say "Yes" to strict mode)
cd demo
code .
Enable extension's Ivy mode when proposed
Try writing any HTML tag in AppComponent template: no autocomplete at all
ng g component demo
Try writing <app-de in AppComponent template: no autocomplete at all (but if I manually write the full tag, the language service is OK with it)

Note: there is the same issue with external templates (in this case you have HTML tags autocomplete because it's a HTML file, but you have no more components tags autocomplete).

Expected behavior

Components / HTML tags should be suggested.

Logs

[Info  - 4:44:27 PM] Angular language server process ID: 6223
[Info  - 4:44:27 PM] Using typescript/lib/tsserverlibrary v4.1.5 from /Users/xxx/.vscode/extensions/angular.ng-template-11.2.2/node_modules/typescript/lib/tsserverlibrary.js
[Info  - 4:44:27 PM] Using @angular/language-service/bundles/ivy v11.2.1 from /Users/xxx/.vscode/extensions/angular.ng-template-11.2.2/node_modules/@angular/language-service/bundles/ivy.js
[Info  - 4:44:27 PM] Log file: /Users/xxx/Library/Application Support/Code/logs/20210222T163701/exthost1/Angular.ng-template/nglangsvc.log
[Info  - 4:44:30 PM] Enabling Ivy language service for /Users/xxx/xxx/xxx/lsivyissue/tsconfig.json.

The log file is empty.

Additional context

VS Code version: 1.53.2
Extension and Angular project version: 11.2.2
OS: macOS 11.2.1 (Intel)
No other extension.

The text was updated successfully, but these errors were encountered:

reed-lawrence · 2021-02-22T19:25:45Z

+1

I have the same issue. As a quick fix, disabling the experimental Ivy features in VS Code settings, the completion returns to expected behavior.

CthulhuOfStars · 2021-02-24T14:45:47Z

Same behavior + always crash

Thanks

jpike88 · 2021-02-25T08:47:10Z

Same problem, enabling the ivy engine makes it no longer recognise component tags, something is broken

tnastula · 2021-02-25T11:05:42Z

Same problem. @reed-lawrence suggested good temporary solution.

The compiler's parsing code has logic to recover from incomplete open tags (i.e. `<div`) but the recovery logic does not handle when the incomplete tag is terminated by an EOF. This commit updates the logic to allow for the EOF character to be interpreted as the end of the tag open so that the parser can continue processing. It will then fail to find the end tag and recover by marking the open tag as incomplete. Part of angular/vscode-ng-language-service#1140

An opening tag `<` without any characters after it is interperted as a text node (just a "less than" character) rather than the start of an element in the template AST. This commit adjusts the autocomplete engine to provide element autocompletions when the nearest character to the left of the cursor is `<`. Note that this also allows for spaces between the `<` so `< ¦` will also provide element autocomplete, much like other extensions such as Emmet. Part of the fix for angular/vscode-ng-language-service#1140

…sion for LS The current logic in the compiler is to bail when there are errors when parsing a template into an HTML AST or when there are errors in the i18n metadata. As a result, a template with these types of parse errors _will not have any information for the language service_. This is because we never attempt to conver the HTML AST to a template AST in these scenarios, so there are no template AST nodes for the language service to look at for information. In addition, this also means that the errors are never displayed in the template to the user because there are no nodes to map the error to. This commit adds an option to the template parser to temporarily ignore the html parse and i18n meta errors and always perform the template AST conversion. At the end, the i18n and HTML parse errors are appended to the returned errors list. While this seems risky, it at least provides us with more information than we had before (which was 0) and it's only done in the context of the language service, when the compiler is configured to use poisoned data (HTML parse and i18n meta errors can be interpreted as a "poisoned" template). fixes angular/vscode-ng-language-service#1140

…le (#41054) The compiler's parsing code has logic to recover from incomplete open tags (i.e. `<div`) but the recovery logic does not handle when the incomplete tag is terminated by an EOF. This commit updates the logic to allow for the EOF character to be interpreted as the end of the tag open so that the parser can continue processing. It will then fail to find the end tag and recover by marking the open tag as incomplete. Part of angular/vscode-ng-language-service#1140 PR Close #41054

An opening tag `<` without any characters after it is interperted as a text node (just a "less than" character) rather than the start of an element in the template AST. This commit adjusts the autocomplete engine to provide element autocompletions when the nearest character to the left of the cursor is `<`. Part of the fix for angular/vscode-ng-language-service#1140

…sion for LS The current logic in the compiler is to bail when there are errors when parsing a template into an HTML AST or when there are errors in the i18n metadata. As a result, a template with these types of parse errors _will not have any information for the language service_. This is because we never attempt to conver the HTML AST to a template AST in these scenarios, so there are no template AST nodes for the language service to look at for information. In addition, this also means that the errors are never displayed in the template to the user because there are no nodes to map the error to. This commit adds an option to the template parser to temporarily ignore the html parse and i18n meta errors and always perform the template AST conversion. At the end, the i18n and HTML parse errors are appended to the returned errors list. While this seems risky, it at least provides us with more information than we had before (which was 0) and it's only done in the context of the language service, when the compiler is configured to use poisoned data (HTML parse and i18n meta errors can be interpreted as a "poisoned" template). fixes angular/vscode-ng-language-service#1140

…41068) An opening tag `<` without any characters after it is interperted as a text node (just a "less than" character) rather than the start of an element in the template AST. This commit adjusts the autocomplete engine to provide element autocompletions when the nearest character to the left of the cursor is `<`. Part of the fix for angular/vscode-ng-language-service#1140 PR Close #41068

…sion for LS (#41068) The current logic in the compiler is to bail when there are errors when parsing a template into an HTML AST or when there are errors in the i18n metadata. As a result, a template with these types of parse errors _will not have any information for the language service_. This is because we never attempt to conver the HTML AST to a template AST in these scenarios, so there are no template AST nodes for the language service to look at for information. In addition, this also means that the errors are never displayed in the template to the user because there are no nodes to map the error to. This commit adds an option to the template parser to temporarily ignore the html parse and i18n meta errors and always perform the template AST conversion. At the end, the i18n and HTML parse errors are appended to the returned errors list. While this seems risky, it at least provides us with more information than we had before (which was 0) and it's only done in the context of the language service, when the compiler is configured to use poisoned data (HTML parse and i18n meta errors can be interpreted as a "poisoned" template). fixes angular/vscode-ng-language-service#1140 PR Close #41068

…41068) An opening tag `<` without any characters after it is interperted as a text node (just a "less than" character) rather than the start of an element in the template AST. This commit adjusts the autocomplete engine to provide element autocompletions when the nearest character to the left of the cursor is `<`. Part of the fix for angular/vscode-ng-language-service#1140 PR Close #41068

angular-automatic-lock-bot · 2021-04-03T16:01:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cyrilletuzi added the bug label Feb 22, 2021

atscott mentioned this issue Mar 2, 2021

fix(compiler): recover from an incomplete open tag at the end of a file angular/angular#41054

Closed

atscott mentioned this issue Mar 3, 2021

fix(language-service): provide autocomplete results for incomplete element tags angular/angular#41068

Closed

zarend closed this as completed in angular/angular@0847a03 Mar 3, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No more completion for components / HTML tags in Ivy mode #1140

No more completion for components / HTML tags in Ivy mode #1140

cyrilletuzi commented Feb 22, 2021 •

edited

Loading

reed-lawrence commented Feb 22, 2021 •

edited

Loading

CthulhuOfStars commented Feb 24, 2021

jpike88 commented Feb 25, 2021

tnastula commented Feb 25, 2021

angular-automatic-lock-bot bot commented Apr 3, 2021

No more completion for components / HTML tags in Ivy mode #1140

No more completion for components / HTML tags in Ivy mode #1140

Comments

cyrilletuzi commented Feb 22, 2021 • edited Loading

reed-lawrence commented Feb 22, 2021 • edited Loading

CthulhuOfStars commented Feb 24, 2021

jpike88 commented Feb 25, 2021

tnastula commented Feb 25, 2021

angular-automatic-lock-bot bot commented Apr 3, 2021

cyrilletuzi commented Feb 22, 2021 •

edited

Loading

reed-lawrence commented Feb 22, 2021 •

edited

Loading