-
Notifications
You must be signed in to change notification settings - Fork 122
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: do not watch directories in google3
In google3, all the dependencies of a TypeScript program are known ahead of time and they are listed in `tsconfig.json`. For this reason, there is no need to watch `node_modules` directory. Tsserver in google3 has additonal patch that explicitly prohibits watching directories that start with `/google/src`. This was not detected during development because we did not actually use the TypeScript module specified in `typescript.tsdk`. The dynamic loading of the `typescript` module requires the server code to be compiled in AMD first, which happens only during the production build.
- Loading branch information
Keen Yee Liau
committed
Mar 4, 2021
1 parent
9182c4c
commit 6a8a2d9
Showing
3 changed files
with
15 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters