Skip to content

Commit

Permalink
fix: do not minify the client code
Browse files Browse the repository at this point in the history
When switching from rollup to esbuild, we enabled minification of
the client code for the first time. This ended up breaking the
extension on Windows machines. This commit removes the minification
and should resolve the broken activation on Windows.

Fixes #1198
  • Loading branch information
atscott committed Mar 15, 2021
1 parent da3fbc7 commit 155aeff
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion esbuild.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ const clientConfig = {
'vscode-jsonrpc',
],
format: 'cjs',
minify: true,
// Do not enable minification. It seems to break the extension on Windows (with WSL). See #1198.
minify: false,
};

/** @type esbuild.BuildOptions */
Expand Down

0 comments on commit 155aeff

Please sign in to comment.