Skip to content

Commit

Permalink
fix: remove message about disabled LS if ngcc fails (#1359)
Browse files Browse the repository at this point in the history
The log message is misleading because LS is enable even if ngcc fails.

(cherry picked from commit 08a5aec)
  • Loading branch information
Keen Yee Liau authored and atscott committed May 17, 2021
1 parent ba13858 commit 0fdc5fb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions server/src/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1123,9 +1123,9 @@ export class Session {
success = true;
} catch (e) {
this.error(
`Failed to run ngcc for ${configFilePath}:\n` +
` ${e.message}\n` +
` Language service will remain disabled.`);
`Failed to run ngcc for ${
configFilePath}, language service may not operate correctly:\n` +
` ${e.message}`);
} finally {
this.connection.sendProgress(NgccProgressType, NgccProgressToken, {
done: true,
Expand Down Expand Up @@ -1169,4 +1169,4 @@ function isTypeScriptFile(path: string): boolean {

function isExternalTemplate(path: string): boolean {
return !isTypeScriptFile(path);
}
}

0 comments on commit 0fdc5fb

Please sign in to comment.