Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Spelling updates to comments #4797

Merged
merged 1 commit into from
May 10, 2018
Merged

Spelling updates to comments #4797

merged 1 commit into from
May 10, 2018

Conversation

drew0530
Copy link
Contributor

@drew0530 drew0530 commented May 7, 2018

fix(comments): Spelling updates to some of the comments

--Changes:

  • line 43: changed 'onPreare' to 'onPrepare'
  • line 46: changed 'funtions' to 'functions'
  • line 103: fixed punctuation, replaced a period with a semicolon to combine sentence fragments

Updated some of the spelling errors/ punctuation mistakes for clearer understanding.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@drew0530
Copy link
Contributor Author

drew0530 commented May 7, 2018

I signed it!
@googlebot

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 7, 2018
@qiyigg
Copy link
Contributor

qiyigg commented May 8, 2018

The change looks good to me, could you update the commit message according to https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#commit-messages

Thanks

@qiyigg qiyigg merged commit c6703a5 into angular:master May 10, 2018
awarecan pushed a commit to awarecan/protractor that referenced this pull request May 10, 2018
Updated some of the spelling errors/ punctuation mistakes for clearer understanding.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants