Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(config): allow CoffeeScript 1.7 to be used #473

Closed
wants to merge 1 commit into from
Closed

fix(config): allow CoffeeScript 1.7 to be used #473

wants to merge 1 commit into from

Conversation

eddiemonge
Copy link
Contributor

CoffeeScript now requires a register call to be made.

Ref #38

CoffeeScript now requires a register call to be made.

Ref #38
@juliemr
Copy link
Member

juliemr commented Jan 29, 2014

Is this backwards compatible for older versions of coffeescript?

@eddiemonge
Copy link
Contributor Author

Yes. I tested with 1.6.3. I can test even older versions too if you would like but it seems like it should work there too

@eddiemonge
Copy link
Contributor Author

Oh, yeah it will work on older versions as well since the require and the call are both in a try/catch block. Older versions dont have the register() function attached so it will fail but the require part will still load CS so its ok that it fails

@brandonaaskov
Copy link

Thank you very much for this fix! Much needed 👍

For others looking to integrate this as well (hopefully it gets merged ASAP).

In my package.json:
Under devDependencies:
"protractor": "git://github.com/eddiemonge/protractor.git#csupdate"

Under scripts:
"e2e": "webdriver-manager start & protractor protractor.conf.js"

With that, I can just npm run e2e and it kicks it off.

@juliemr
Copy link
Member

juliemr commented Jan 31, 2014

Thanks! Merged as 5dd93c2

@juliemr juliemr closed this Jan 31, 2014
@eddiemonge eddiemonge deleted the csupdate branch January 31, 2014 23:07
@eddiemonge eddiemonge restored the csupdate branch January 31, 2014 23:07
@eddiemonge eddiemonge deleted the csupdate branch January 31, 2014 23:07
@eddiemonge
Copy link
Contributor Author

@brandonaaskov you should update your package.json since I deleted that branch now that this has landed in protractor#master

@brandonaaskov
Copy link

Thanks @juliemr and @eddiemonge! Love me some coffeescript :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants