Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

feat(config): allow CoffeeScript configuration files #399

Closed
wants to merge 1 commit into from
Closed

feat(config): allow CoffeeScript configuration files #399

wants to merge 1 commit into from

Conversation

eddiemonge
Copy link
Contributor

Require CoffeeScript in the cli file to enable CS configuration and spec files. No other changes are needed to get CS files working. Possibly needs a readme or doc for the by issue but I haven't researched that much yet

Possibly fixes #38

Require CoffeeScript in the cli file to enable CS configuration and spec
files.

Possibly fixes #38
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@juliemr
Copy link
Member

juliemr commented Jan 10, 2014

I really don't want to introduce coffee script into Protractor's dependencies - the require can be done inside your config file, which seems like a cleaner solution. Maybe we can just document that option better instead?

@eddiemonge
Copy link
Contributor Author

Then your config must be a JS file and not a CS file

@juliemr
Copy link
Member

juliemr commented Jan 10, 2014

OK, I think the only thing opposing this is me being stubborn:

  • coffeescript is not a large dep (412K)
  • it's consistent with the way Karma includes coffeescript

So, merging.

@juliemr
Copy link
Member

juliemr commented Jan 10, 2014

Merged as 7259614

@juliemr juliemr closed this Jan 10, 2014
@juliemr
Copy link
Member

juliemr commented Jan 10, 2014

Quick note: spoke with Karma folks and updated to the following: 0257b5f

This allows the user to install coffee script but ignores failures if it's not present.

@eddiemonge eddiemonge deleted the cssupport branch January 10, 2014 21:57
@andrewboni
Copy link

Is there an example somewhere of how to set up the protractorConf file (and specs for that matter) to use CoffeeScript? Just updated to Protractor 0.16.1, and am having trouble getting my JS specs to run with a protractorConf.coffee file.

@eddiemonge
Copy link
Contributor Author

in your main project, you have to npm install --save coffee-script then it should start working like a champ. Thats after you checkout the project and npm link from inside the protractor directory since this change isn't pushed to npm yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coffeescript preprocessor
4 participants