This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
refactor(browser): Remove wrapDriver #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the commit message lists the breaking change |
heathkit
force-pushed
the
no-wrapdriver
branch
from
dc28611 to
8a2471f
Compare
This is a **breaking change**.
Before:
Users could create their own selenium driver instance and enable Protractor on
it like so:
```js
let capabilities = webdriver.Capabilities.chrome();
let driver = new webdriver.Builder().usingServer(seleniumAddress)
.withCapabilities(capabilities).build();
let browser = protractor.wrapDriver(driver);
```
Over the years, wrapDriver() has become increasingly broken as Protractor
needs extra configuration options that wrapDriver() doesn't set.
After:
This method is removed. If users need a new browser instance, they can
use `browser.forkNewDriverInstance()`.
heathkit
force-pushed
the
no-wrapdriver
branch
from
92e6050 to
48b2a97
Compare
heathkit
added a commit
to heathkit/protractor
that referenced
this pull request
Dec 19, 2016
…angular#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 19, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 20, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 21, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 22, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 28, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
sjelin
pushed a commit
that referenced
this pull request
Dec 28, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
juliemr
pushed a commit
that referenced
this pull request
Dec 29, 2016
…#3827) Before: Users could create their own selenium driver instance and enable Protractor on it like so: ```js let capabilities = webdriver.Capabilities.chrome(); let driver = new webdriver.Builder().usingServer(seleniumAddress) .withCapabilities(capabilities).build(); let browser = protractor.wrapDriver(driver); ``` Over the years, wrapDriver() has become increasingly broken as Protractor needs extra configuration options that wrapDriver() doesn't set. After: This method is removed. If users need a new browser instance, they can use `browser.forkNewDriverInstance()`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.