This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
dep(types): typescript and typings dependencies #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cnishina
commented
Aug 18, 2016
cnishina
commented
- remove typings dependency, scripts, and gulp task
- add @types dependencies
- clean up globals.ts from npm publishing
- remove typings dependency, scripts, and gulp task - add @types dependencies - clean up globals.ts from npm publishing
|
@robinboehm I plan to rollback your change. The transpile to I did however update the Protractor Cookbook with the |
|
@robinboehm just kidding... I was able to get this to work with @tmeneau's help. |
- add declaration flag for gulp task - ignore globals.d.ts from tsconfig and .gitignore - put back outDir in exampleTypescript
| @@ -14,3 +14,4 @@ npm-debug.log | |||
|
|
|||
| *.swp | |||
| globals.js | |||
| globals.d.ts | |||
|
yay no more typings.json! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.