chore(types): add in types inherited from selenium-webdriver #3288
Conversation
cnishina
commented
Jun 20, 2016
cnishina
commented
- add element.ts to the gulp task for 'gulp types'
- clang clean up
- separate out selenium-webdriver types and extend them in protractor
- remove webdriver types for index.d.ts file
|
Note: removing |
|
The travis failures look legitimate. |
|
|
||
| var removeTypes = function(line, webdriverType) { | ||
| var tempLine = line.trim(); | ||
| if (tempLine.startsWith('/**') || tempLine.startsWith('*')) { |
There was a problem hiding this comment.
They would usually start with * for multiline comments. (That didn't show up well, it's a space in front of the *)
There was a problem hiding this comment.
This should be fine because I am trimming the line prior to testing if it starts with a *. This should capture the comments in the index.d.ts file.
|
It looks like I went a little overboard trying to clean up the ptor file. |
cnishina
force-pushed
the
pr_typings_tests
branch
2 times, most recently
from
0a26e70 to
3b49349
Compare
| @@ -14,6 +14,40 @@ let WEB_ELEMENT_FUNCTIONS = [ | |||
| 'serialize', 'takeScreenshot' | |||
| ]; | |||
|
|
|||
| // Explicitly extend selenium webdriver for webdriver.WebElement. | |||
| export class WebdriverWebElement { | |||
There was a problem hiding this comment.
Would it make more sense for these to be interfaces instead of classes?
There was a problem hiding this comment.
Changing this to be an interface.
cnishina
force-pushed
the
pr_typings_tests
branch
2 times, most recently
from
8295523 to
d7e65f4
Compare
- add element.ts to the gulp task for 'gulp types' - clang clean up - separate out selenium-webdriver types and extend them in protractor - remove webdriver types for index.d.ts file
