Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(testapp): Use newer angular beta #3121

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Conversation

sjelin
Copy link
Contributor

@sjelin sjelin commented Apr 12, 2016

Need this for #3024

@cnishina
Copy link
Member

This looks fine except this definitely makes the flaky test #3000 fail 100% of the time. This could might need some attention.

@cnishina
Copy link
Member

Should probably get #3127 merged in first to pass this test. Other than that, LGTM

@sjelin
Copy link
Contributor Author

sjelin commented Apr 15, 2016

Blocked on angular/angular#8089. Assigning Julie since that bug is much more her domain.

@juliemr
Copy link
Member

juliemr commented Apr 25, 2016

See angular/angular#8219

We decided this is not blocked, since we should be running setTimeout outside of the Angular zone.

@sjelin
Copy link
Contributor Author

sjelin commented Apr 26, 2016

setInterval is now being run outside of NgZone

@sjelin
Copy link
Contributor Author

sjelin commented Apr 27, 2016

Craig assigning back to you since you're on call

@sjelin sjelin merged commit 3083097 into angular:master Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants