This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(jasmine2): upgrade jasmine to 2.2 #1795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable spec-based timeout (i.e. it('description', test_func, timeout))
and proper stack trace propagation
|
Looks like tests are failing because the fix that I submitted for matching arrays from different contexts is not yet in jasmine. Can we wait for that? |
|
Doesn't seem like we have a choice :P |
|
I'm going to close this for now then since it's going to be a while before they release a new version |
|
Reopening so it's more searchable and I can remember what's going on :P |
|
Waiting for a release with jasmine/jasmine#767 |
|
Hi, Issue is resolved by upgrading to 2.2.1 |
|
Update! Jasmine 2.3.0 is out. Protractor will test and update soon. |
juliemr
added a commit
to juliemr/protractor
that referenced
this pull request
May 15, 2015
Updated from 2.1.1. See Jasmine's changelog at https://github.com/jasmine/jasmine/tree/master/release_notes Closes angular#1795. Closes angular#2094. Closes angular#1768.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable spec-based timeout (i.e. it('description', test_func, timeout))
and proper stack trace propagation