fix issue where color formatting text is leaking #1216
Conversation
| @@ -310,11 +310,17 @@ TaskReporter_.prototype.log_ = function(data) { | |||
| for ( var i = 0; i < data.length; i++ ) { | |||
| if (this.insertTag) { | |||
| this.insertTag = false; | |||
| if (data[i] === '\x1B' && data.substring(i, i+4) === '\x1B[0m' ) { | |||
There was a problem hiding this comment.
can we add a comment here on what this craziness is doing?
There was a problem hiding this comment.
Basically, jasmines sends back colored strings as:
\x1B[31mSome text\n\x1B[0mnew line
which gets formatted into
[color]Some text[/color]
[no color]new line[/no color]
However, if you simply add a new tag after the \n, the \x1B[0m appears before the text (and after the tag) in the new line. This is not an issue if you are using console or something that process the \x1B[0m properly. But if the \x1B[0m is not processed, then the \x1B[0m becomes concatenated with the info.
This craziness basically append the tag only after the \x1B[0m.
There was a problem hiding this comment.
another note, technically data.substring(i, i+4) === '\x1B[0m' is all that's needed to do the job, but I did data[i] === '\x1B' && data.substring(i, i+4) === '\x1B[0m' as a slight optimization to avoid running a substring on every character.
There was a problem hiding this comment.
Oh I mean add a comment to the actual code so that we'll know what's going on in 2 months.
hankduan
force-pushed
the
fix_report_color
branch
from
f3a6379 to
46866c2
Compare
|
added comment |
|
LGTM |
|
committed with 9814af1 |
See #1131