Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
fix(webdriver-manager): always use https for downloading webdriver bi…
Browse files Browse the repository at this point in the history 
…naries

This fixes issues with unzipping - see #1259
  • Loading branch information
@juliemr
juliemr committed Aug 29, 2014
1 parent 2972e3a commit ade9a92
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bin/webdriver-manager
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var binaries = {
prefix: 'selenium-server-standalone',
filename: 'selenium-server-standalone-' + versions.selenium + '.jar',
url: function() {
return 'http://selenium-release.storage.googleapis.com/' +
return 'https://selenium-release.storage.googleapis.com/' +
shortVersion(versions.selenium) + '/' +
'selenium-server-standalone-' + versions.selenium + '.jar';
}
Expand All @@ -43,7 +43,7 @@ var binaries = {
prefix: 'chromedriver_',
filename: 'chromedriver_' + versions.chromedriver + '.zip',
url: function() {
var urlPrefix = 'http://chromedriver.storage.googleapis.com/' +
var urlPrefix = 'https://chromedriver.storage.googleapis.com/' +
versions.chromedriver + '/chromedriver_';
if (os.type() == 'Darwin') {
return urlPrefix + 'mac32.zip';
Expand All @@ -64,7 +64,7 @@ var binaries = {
prefix: 'IEDriverServer',
filename: 'IEDriverServer_' + versions.iedriver + '.zip',
url: function() {
var urlPrefix = 'http://selenium-release.storage.googleapis.com/' +
var urlPrefix = 'https://selenium-release.storage.googleapis.com/' +
shortVersion(versions.iedriver) + '/IEDriverServer';
if (os.type() == 'Windows_NT') {
if (os.arch() == 'x64') {
Expand Down

1 comment on commit ade9a92

@Chexpir
Copy link

@Chexpir Chexpir commented on ade9a92 Sep 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I don't think this resolves the issue, as everybody still have this error randomly.

node ./node_modules/protractor/bin/webdriver-manager update

Updating selenium standalone
downloading https://selenium-release.storage.googleapis.com/2.42/selenium-server-standalone-2.42.2.jar...
Updating chromedriver
downloading https://chromedriver.storage.googleapis.com/2.10/chromedriver_linux64.zip...
chromedriver_2.10.zip downloaded to /home/jenkins/workspace/CC-J-cc_builder_e2e-T-master-IntSonar/node_modules/protractor/selenium/chromedriver_2.10.zip

Invalid or unsupported zip format. No END header found

Please sign in to comment.