Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
chore(testapp): change the default port from 8000 to 8081
Browse files Browse the repository at this point in the history
This prevents conflicts with the default port for the angular.js application.

Closes #887
  • Loading branch information
juliemr committed Jun 4, 2014
1 parent fbfc72b commit 46a8ca5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion referenceConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ exports.config = {
//
// A base URL for your application under test. Calls to protractor.get()
// with relative paths will be prepended with this.
baseUrl: 'http://localhost:' + (process.env.HTTP_PORT || '8000'),
baseUrl: 'http://localhost:9876',

This comment has been minimized.

Copy link
@elgalu

elgalu Jun 4, 2014

Contributor

I lost here Julie, should this be 8081?

This comment has been minimized.

Copy link
@juliemr

juliemr Jun 4, 2014

Author Member

Ah, this one doesn't really matter. We never run the reference conf at all, so it's just for show. I though the process.env.HTTP_PORT was probably confusing for someone just wanting a reference, so I removed it and picked a new random port.

This comment has been minimized.

Copy link
@elgalu

elgalu Jun 4, 2014

Contributor

Face palm for me :)


// Selector for the element housing the angular app - this defaults to
// body, but is necessary if ng-app is on a descendant of <body>
Expand Down
2 changes: 1 addition & 1 deletion spec/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ module.exports = {
// A base URL for your application under test.
baseUrl:
'http://' + (process.env.HTTP_HOST || 'localhost') +
':' + (process.env.HTTP_PORT || '8000')
':' + (process.env.HTTP_PORT || '8081')

};
2 changes: 1 addition & 1 deletion testapp/scripts/web-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
var express = require('express');
var util = require('util');
var testApp = express();
var DEFAULT_PORT = process.env.HTTP_PORT || 8000;
var DEFAULT_PORT = process.env.HTTP_PORT || 8081;
var testAppDir = require('path').resolve(__dirname, '..');

var main = function(argv) {
Expand Down

0 comments on commit 46a8ca5

Please sign in to comment.