Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
fix(navigation): ignore unknown JS errors in IE (#4149)
Browse files Browse the repository at this point in the history
The `err` object doesn't have the `code` property any more (Selenium Server Standalone 3.3.1 + IEDriver win32 3.3.0), so we need a new way to detect those errors. See #841
  • Loading branch information
thorn0 authored and cnishina committed Mar 15, 2017
1 parent 4752ad1 commit 0eb5b76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver {
return url !== this.resetUrl;
},
(err: IError) => {
if (err.code == 13) {
if (err.code == 13 || err.name === 'JavascriptError') {
// Ignore the error, and continue trying. This is
// because IE driver sometimes (~1%) will throw an
// unknown error from this execution. See
Expand Down

0 comments on commit 0eb5b76

Please sign in to comment.