Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

layout-fill firefox fix #824

Closed
wants to merge 1 commit into from
Closed

Conversation

rem4ik4ever
Copy link

Fixed layout-fill for Firefox so it only fills

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@rem4ik4ever rem4ik4ever closed this Dec 3, 2014
@rem4ik4ever rem4ik4ever reopened this Dec 3, 2014
@rem4ik4ever
Copy link
Author

Seems like i have troubles with signing in to CLA. I have already registered on both my emails. Still no response from googlebot

@m1kl
Copy link

m1kl commented Dec 30, 2014

@rem4ik4ever: I also have to add height: inherit; to your fix so I get it to work in firefox.

@rschmukler
Copy link
Contributor

Merged, thank you!

@rschmukler rschmukler closed this Jan 7, 2015
[layout-fill] {
margin: 0;
width: 100%;
min-height: auto;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this does as intended. In FF, layout-fill no longer makes a container full height, and overflow breaks in e.g. md-content. Works in Chrome.

@dnadoba
Copy link

dnadoba commented Feb 24, 2015

min-height: auto
dosen't work as excepted
i have tried
min-height: 0
and it worked like in chrome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants