fix(chips): fix chips focus functionality

[devversion]

• The normal mobile devices won't trigger the focus on the element.
  Focusing the element on ng-click fixes that issue.
  Through keeping and redirecting to ng-focus it's still possible to select chips through keyboard
• At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes #5897 Fixes #5662

[topherfangio]

@devversion Can you please provide a test for this change?

[devversion]

@topherfangio - I added two new tests for the chips, one for the new click / touch feature and even for the normal function focus. Due rebasing to master there is the well known ws error, but I can show a few screenshots with using karma/stable.

If I remove the ng-click line

If I only remove the ng-focus line

Otherwise it succeed

So the test works as expected.

Update: Merged PR #5795 into this commit and added a extra test for chip bluring.

[topherfangio]

@devversion Thanks for the updates. Strange thing, all three of the new tests are failing for me in Firefox 42.

Are you sure you pushed your latest changes?

Also, can you change your lines from .toHaveBeenCalled() to .toHaveBeenCalledTimes(1)? I am worried that this change might accidentally call the selectChip() function twice if the browser fires both a click and a focus event.

[devversion]

@topherfangio,

I'm sure I uploaded the latest version, and my tests succeed.

What Karma Version are you using?, that's very strange

---

Done, I changed it to toHaveBeenCalledTimes

[topherfangio]

@devversion Not sure what was wrong with my machine, but it appears to be passing now, and it's passing on Travis, so I think we're good.

@ThomasBurleson This should be good to merge whenever is convenient.

[devversion]

@topherfangio I runned my tests locally again, and they fail 😨. That's really strange. I try to rework that

[topherfangio]

Lol! Okay, since you're seeing the failures too, I'm guessing that it's an issue with the order that the tests are run in.

I've marked this as "needs work" until we can dig in a bit further.

Thanks for looking into it!

[devversion]

@topherfangio - Okay I fixed it :D - Should be ready for merge now

[topherfangio]

@devversion How did you fix the failing tests? It's not easy to see differences between squashed commits 😄

[devversion]

@topherfangio Sorry for instant squash 😄 I just replaced .click() with triggerHandler

[topherfangio]

@devversion No worries on the squashing! It is what we prefer; it just makes it difficult to look back in history ;-)

Thanks for the update. I'll re-mark this as ready for merge.

[devversion]

@ThomasBurleson That was an issue with evalAsync, which was suggested for this PR. But reverted it back to applyAsync and now everything works great again.

[topherfangio]

@devversion Can you rebase this one too? Looks like the build is failing and needs the same update as the other PR you just fixed.

[devversion]

@topherfangio Yes sure. Rebased :)

[topherfangio]

@ThomasBurleson Just tested this and specifically looked for the issue you found/mentioned above. It appears to be fixed and the demos appear to work correctly. Should be ready for merge now.

[topherfangio]

@ThomasBurleson Just a quick ping to say that this is ready for merge. Can probably wait until 1.1.1 though.