Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fixed issue with dialog double opening and inability to close second dialog. #5157

Closed
wants to merge 2 commits into from
Closed

Fixed issue with dialog double opening and inability to close second dialog. #5157

wants to merge 2 commits into from

Commits on Oct 15, 2015

  1. (test dialog) Added tests for testing dialog double opening. 

    There seems to be a bug which prevents a dialog from being closed
if it's opened while another dialog is shown.
    @erikogenvik
    erikogenvik committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    06a724f View commit details
    Browse the repository at this point in the history

  2. (fix dialog) Make sure dialog only destroys itself. 

    Since destruction is deferred, there's a risk of another dialog
having been created by the time "destroy()" is called.
We therefore have to make sure that we only remove one from the stack
if it's still left in it (which would be the case if "destroy()"
gets called as a result of the scope being destroyed independently,
but wouldn't be the case if the dialog is destroyed as a result of
calling $mdDialog.hide()).
    @erikogenvik
    erikogenvik committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    17f4c19 View commit details
    Browse the repository at this point in the history