This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Fixing md-tooltip on Firefox issues #3047, #3250 and #3430 #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
evertonrobertoauler
changed the title
|
@evertonrobertoauler - I cannot merge this without a signed CLA. |
| @@ -129,7 +129,7 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $mdUtil, $mdThe | |||
| function bindEvents () { | |||
| var mouseActive = false; | |||
| var enterHandler = function() { | |||
| if (!hasComputedStyleValue('pointer-events','none')) { | |||
There was a problem hiding this comment.
This change does not make sense. The three valid pointer-events style values for any HTML element are:
- auto
- inherit
- none
|
Closed with 6fc9212 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var computedStyles = $window.getComputedStyle(element[0]);
console.log(computedStyles['pointer-events'] ); // Firefox returns 'none' as string
console.log(computedStyles['pointer-events'] ); // Chrome returns an empty string ''
The problem is that hasComputedStyleValue('pointer-events','none') always returns true on Firefox and setVisible(true); is not being called.
All the tests are still passing and now the Tooltip works fine on Chrome and Firefox again.