This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix($mdUtil): make "initOptionalProperties" compatible with angular >= 1.4.1 #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= 1.4.1 starting form angular 1.4.1 attrs defined in directive isolated scope are always present in $attrs Closes #3315
| */ | ||
| initOptionalProperties: function (scope, attr, defaults ) { | ||
| defaults = defaults || { }; | ||
| angular.forEach(scope.$$isolateBindings, function (binding, key) { | ||
| var normalizedAttrName = attr.$normalize(binding.attrName); |
There was a problem hiding this comment.
This is redundant (I don't know why it was there in the first place).
binding.attrName is already normalized.
|
I've simplified this fix as gkalpak suggested. |
kseamon
added a commit
to kseamon/material
that referenced
this pull request
Jun 18, 2015
Implements a virtual repeater to use instead of ng-repeat for substantially better performance in components. review edits Make tests pass in FF. fix(tabs): prevents error on empty tab list Closes angular#3264 fix(button): fixes button styles for components that override their default styles chore(toast): fix type typo in toast docs (`boolean` > `string`). fix(utils): update for Angular 1.4.1 compatibility Fixes angular#3315, Fixes angular#3325. fix(icons): improve use of material-icons style Improve logic to auto-add `.material-icons` style to **md-icon**. > NOTE: will not auto-add if using any class or ng-class attributes; see demoFontIconsWithLigatures Fixes angular#3333. update(icon): removed **ddescribe** used for isolated karma tests update(docs, icon): clarify auto-add of 'material-icons' style. update(build): use of Angular v1.4.1 update(util): update initOptionalProperties() implementation Closes angular#3316. feat(menu): do not propagate event in mdOpenMenu Do not propagate the event in mdOpenMenu. This way a menu can be nested in elements that also have handlers of the same event type, without triggering any of these events. To enable this functionality, `$event` should be passed as the first argument to `$mdOpenMenu`. Fixes angular#3296. Closes angular#3332. update(tests, mocks): test for stopPropogation angular-material-mocks captures $timeout.flush() errors. add menu event propogation test Switched RawGit for GitCDN Switch to GitCDN, which lets you get the latest master branch, without losing the CDN and without it's service getting harmed. Closes angular#3262. update(README): change docs to reference 0.10.0 Closes angular#3319.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting form angular 1.4.1 attrs defined in directive isolated scope are always present in $attrs
Closes #3315